Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

xref #39146

@jorisvandenbossche jorisvandenbossche added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Mar 3, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.3 milestone Mar 3, 2021
numeric=numeric,
timedelta=timedelta,
)
def _convert(arr):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pretty but ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's not pretty about it? The inline function?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soft_convert_objects can just do this directly right? (or the copy keyword is not functioning)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently soft_convert_objects assumes the input is object dtype, and doesn't do such checking. I assume the check could be moved into soft_convert_objects as well (although eg for Block, which has an ObjectBlock, it knows it is ndarray[object], and such an additional check would be unnecessary)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW soft_convert_objects is only used for ObjectBlock.convert ATM, so no real harm in making it handle non-object with these extra two lines (though to get effective simplification in the BM code might need to tweak copy kwarg behavior)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok if would revisit / consolidate logic at some point here.

@jreback jreback merged commit 7f2fc6a into pandas-dev:master Mar 5, 2021
@jorisvandenbossche jorisvandenbossche deleted the am-convert branch March 5, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants